opencensus-erlang icon indicating copy to clipboard operation
opencensus-erlang copied to clipboard

Published 20 hours ago • verified publisher icon census-instrumentation

adds set_kind func for oc_trace

Open castengo opened this issue 4 years ago • 2 comments

castengo avatar Aug 13 '20 21:08 castengo

My first thought was that maybe the spec said kind could only be set when a span is started. I can't find that in the spec so I guess this is fine, only issue is the test using a binary instead of an atom.

tsloughter avatar Aug 13 '20 22:08 tsloughter

yeah we are starting the trace with_child_span since its a remote trace, so I could also add it as an option to that func if you think its better.

I'll change that to an atom, thanks for reviewing!

castengo avatar Aug 13 '20 23:08 castengo