opencensus-erlang icon indicating copy to clipboard operation
opencensus-erlang copied to clipboard

format b3 headers as 16 chars when 64 bit

Open castengo opened this issue 4 years ago • 3 comments

Since b3 trace IDs can be either 64 or 128 bit, we should check the size of the traceID and encode it according to its size instead of always encoding it as 32 chars.

castengo avatar Jul 29 '20 15:07 castengo

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Jul 29 '20 15:07 googlebot

@googlebot I signed it!

castengo avatar Jul 29 '20 15:07 castengo

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Jul 29 '20 15:07 googlebot