cenkore
cenkore
> Add a session3 lock `_gho` table introduce a problem: > If sesssion1 broken after drop table `_t_del`, > then `_gho` table lock has not been released , > then...
Thanks for your quick reply. @shlomi-noach In this PR, if duplicates are on the newly added unique key , it will fail instead of ignore. ### Background Gh-ost contains two...
Add 2 test cases original table definition: `create table uk(id int, name varchar(10),inser_time datetime, primary key(id))` alter: `add unique key(name)` ### Test case 1: prepare: `insert into uk values(1,'cenkore',now())` execute:...
@shlomi-noach ok, I will submit later. Thank you.
@shlomi-noach I submitted to `openark/gh-ost`, but I can’t guarantee the accuracy of my operation, because it's difficult for me which merge is between two forked sibling projects, and your project...
> @cenkore see my previous comment 🙏 @timvaillancourt Sorry for taking a long time to reply you. PTAL.
@shlomi-noach can you take a look ? were really stuck here .
> would this work What needs to be done for this PR ? It's stuck here with "Some checks haven’t completed yet" , and I dont know how to fix...
> @cenkore Looks like the CI pipeline possibly stalled out there. Maybe rebase with the latest master and push the branch up again to kick the CI bits. @zpatten thanks...
I merged latest master into my branch, still stuck here 😔 Any details or build logs ?