react-magma icon indicating copy to clipboard operation
react-magma copied to clipboard

feat(multi combobox): `hasPersistentMenu` prop to keep items visible after selection

Open silvalaura opened this issue 3 years ago β€’ 10 comments

Issue: #947

What I did

Screenshots (if appropriate):

Checklist

  • [ ] changeset has been added
  • [ ] I have made corresponding changes to the documentation
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works

How to test

silvalaura avatar Oct 24 '22 21:10 silvalaura

πŸ¦‹ Changeset detected

Latest commit: 6a0b6992b4f7666b9df643dda022698474ff835c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 24 '22 21:10 changeset-bot[bot]

πŸš€ Deployed on https://docs-preview-946--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] avatar Oct 24 '22 21:10 github-actions[bot]

πŸš€ Deployed on https://storybook-preview-946--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] avatar Oct 24 '22 21:10 github-actions[bot]

πŸš€ Deployed on https://docs-preview-946--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] avatar Oct 24 '22 21:10 github-actions[bot]

πŸš€ Deployed on https://storybook-preview-946--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] avatar Oct 24 '22 21:10 github-actions[bot]

Codecov Report

Base: 86.29% // Head: 86.26% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (9aaf87d) compared to base (85853ea). Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #946      +/-   ##
==========================================
- Coverage   86.29%   86.26%   -0.04%     
==========================================
  Files         176      176              
  Lines        4728     4731       +3     
  Branches     1629     1631       +2     
==========================================
+ Hits         4080     4081       +1     
- Misses        329      330       +1     
- Partials      319      320       +1     
Impacted Files Coverage Ξ”
.../react-magma-dom/src/components/Combobox/index.tsx 100.00% <ΓΈ> (ΓΈ)
...eact-magma-dom/src/components/Select/ItemsList.tsx 95.00% <ΓΈ> (ΓΈ)
...agma-dom/src/components/Combobox/MultiCombobox.tsx 89.41% <75.00%> (-2.06%) :arrow_down:
...agma-dom/src/components/Combobox/ComboboxInput.tsx 72.50% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Oct 25 '22 20:10 codecov-commenter

πŸš€ Deployed on https://docs-preview-946--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] avatar Oct 25 '22 21:10 github-actions[bot]

πŸš€ Deployed on https://storybook-preview-946--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] avatar Oct 25 '22 21:10 github-actions[bot]

πŸš€ Deployed on https://docs-preview-946--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] avatar Oct 26 '22 21:10 github-actions[bot]

πŸš€ Deployed on https://storybook-preview-946--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] avatar Oct 26 '22 21:10 github-actions[bot]

πŸš€ Deployed on https://docs-preview-946--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] avatar Oct 31 '22 19:10 github-actions[bot]

πŸš€ Deployed on https://storybook-preview-946--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] avatar Oct 31 '22 19:10 github-actions[bot]

πŸš€ Deployed on https://docs-preview-946--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] avatar Oct 31 '22 19:10 github-actions[bot]

πŸš€ Deployed on https://storybook-preview-946--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] avatar Oct 31 '22 19:10 github-actions[bot]

πŸš€ Deployed on https://docs-preview-946--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] avatar Oct 31 '22 19:10 github-actions[bot]

πŸš€ Deployed on https://docs-preview-946--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] avatar Oct 31 '22 19:10 github-actions[bot]

πŸš€ Deployed on https://storybook-preview-946--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] avatar Oct 31 '22 19:10 github-actions[bot]

πŸš€ Deployed on https://storybook-preview-946--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] avatar Oct 31 '22 19:10 github-actions[bot]