cengage
fix: switch dropdown component in table pagination to native select
switch out the dropdown component use in the table component to the native select component to fix focus state issue
closes #393
Issue: #393
What I did
Screenshots (if appropriate):
Checklist
- [x] changeset has been added
- [x] I have made corresponding changes to the documentation
- [x] New and existing unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
How to test
π¦ Changeset detected
Latest commit: 06dee6cb0aeb320d138563120956e769e51867fa
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
Base: 86.22% // Head: 86.04% // Decreases project coverage by -0.18% :warning:
Coverage data is based on head (
1ceb174) compared to base (f83cfa1). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## dev #934 +/- ##
==========================================
- Coverage 86.22% 86.04% -0.19%
==========================================
Files 175 175
Lines 4625 4621 -4
Branches 1581 1580 -1
==========================================
- Hits 3988 3976 -12
- Misses 324 326 +2
- Partials 313 319 +6
| Impacted Files | Coverage Ξ | |
|---|---|---|
| ...a-dom/src/components/NativeSelect/NativeSelect.tsx | 100.00% <100.00%> (ΓΈ) |
|
| ...magma-dom/src/components/Table/TablePagination.tsx | 100.00% <100.00%> (ΓΈ) |
|
| ...a-dom/src/components/Dropdown/DropdownMenuItem.tsx | 80.00% <0.00%> (-12.73%) |
:arrow_down: |
| ...ma-dom/src/components/Dropdown/DropdownContent.tsx | 95.45% <0.00%> (-4.55%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
π Deployed on https://docs-preview-934--upbeat-sinoussi-f675aa.netlify.app
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
π Deployed on https://storybook-preview-934--upbeat-sinoussi-f675aa.netlify.app
π Deployed on https://docs-preview-934--upbeat-sinoussi-f675aa.netlify.app
π Deployed on https://docs-preview-934--upbeat-sinoussi-f675aa.netlify.app
π Deployed on https://storybook-preview-934--upbeat-sinoussi-f675aa.netlify.app
π Deployed on https://storybook-preview-934--upbeat-sinoussi-f675aa.netlify.app
π Deployed on https://docs-preview-934--upbeat-sinoussi-f675aa.netlify.app
π Deployed on https://storybook-preview-934--upbeat-sinoussi-f675aa.netlify.app
π Deployed on https://docs-preview-934--upbeat-sinoussi-f675aa.netlify.app
π Deployed on https://storybook-preview-934--upbeat-sinoussi-f675aa.netlify.app
π Deployed on https://docs-preview-934--upbeat-sinoussi-f675aa.netlify.app
π Deployed on https://storybook-preview-934--upbeat-sinoussi-f675aa.netlify.app
I think if we are going to wait to merge this until after our next patch/minor release, we should open a separate PR that we do merge immediately that marks dropdownDropDirection as deprecated. That way, we will have "warned" consumers about the incoming breaking change before we introduce it. Thoughts?
π Deployed on https://docs-preview-934--upbeat-sinoussi-f675aa.netlify.app
π Deployed on https://storybook-preview-934--upbeat-sinoussi-f675aa.netlify.app
We did the same thing with button colors I believe right? V3 required us to drop a couple of them and we documented the change, seemed fine to me.
π Deployed on https://docs-preview-934--upbeat-sinoussi-f675aa.netlify.app
π Deployed on https://storybook-preview-934--upbeat-sinoussi-f675aa.netlify.app
Could not get the Base Pagination props to render in the documentation.
π Deployed on https://docs-preview-934--upbeat-sinoussi-f675aa.netlify.app
π Deployed on https://storybook-preview-934--upbeat-sinoussi-f675aa.netlify.app