react-magma icon indicating copy to clipboard operation
react-magma copied to clipboard
verified publisher icon cengage

TimePicker: Support 12 or 24 hour time format

Open hkrishna29 opened this issue 3 years ago • 1 comments

Describe the bug Should the Time picker be specific to 12 hr clock (which it is currently )or should it be 24hr clock?

To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://storybook-preview-dev--upbeat-sinoussi-f675aa.netlify.app/?path=/story/timepicker--default'
  2. The User is not allowed to update time to a 24 hours clock

Expected behavior Is the design specific to 12 hr clock or should it be 24hr clock?

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [Win10]
  • Browser [chrome]
  • Version [103.0.5060.66 ]

hkrishna29 avatar Jul 05 '22 19:07 hkrishna29

Our I18nContext accepts a timeformat: '12' or '24' but the TimePicker component does not actually use it.

silvalaura avatar Oct 17 '23 21:10 silvalaura