react-magma icon indicating copy to clipboard operation
react-magma copied to clipboard

Update publish-latest.yml

Open silvalaura opened this issue 3 years ago • 1 comments

We should update publish-latest so that we are less likely to release accidentally when something is pushed to the main branch.

We need to discuss as a team how we want to solve this.

Options:

  1. Don't automate this!

  1. Keep automation, but update to:
  • On push to master, ONLY run tests
  • On merge to master, everything we currently do
  • Remove Sync main -> dev step

Other things to still solve for:

  • Could we select which version to release if there are changes for major/minor/patch within dev?
  • Automate creating releases from tags in github

silvalaura avatar May 12 '22 14:05 silvalaura

on:
  pull_request:
    branches:
      - deploy
    types: [closed]

jobs:
  <job id>:
    if: github.event.pull_request.merged == true
    steps: // the rest of the code

https://github.community/t/trigger-workflow-only-on-pull-request-merge/17359/9

silvalaura avatar May 19 '22 17:05 silvalaura