react-magma icon indicating copy to clipboard operation
react-magma copied to clipboard

feat: slider - WIP

Open chris-cedrone-cengage opened this issue 4 years ago • 4 comments

Work remaining:

Laura

  • [ ] Tooltip should be visible on drag
  • [ ] On drag, the cursor loses the marker / When dragging on Marks, the accuracy is off
  • [ ] On Vertical Slider, tooltip should appear on the side
  • [ ] Review accessibility
  • [ ] Update storybook

Chris

  • [ ] Build docs site
  • [ ] Write unit tests
  • [ ] Theming

chris-cedrone-cengage avatar Aug 27 '21 13:08 chris-cedrone-cengage

⚠️ No Changeset found

Latest commit: 1e64bb4c0c9be261daab3e3a21832194ff833d1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 27 '21 13:08 changeset-bot[bot]

Codecov Report

Merging #360 (e2e07e6) into dev (70cc3a5) will decrease coverage by 0.31%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #360      +/-   ##
==========================================
- Coverage   90.44%   90.13%   -0.32%     
==========================================
  Files         154      155       +1     
  Lines        3630     3678      +48     
  Branches     1201     1212      +11     
==========================================
+ Hits         3283     3315      +32     
- Misses        189      201      +12     
- Partials      158      162       +4     
Impacted Files Coverage Δ
...s/react-magma-dom/src/components/Slider/Slider.tsx 66.66% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ffc8d8b...e2e07e6. Read the comment docs.

codecov-commenter avatar Aug 27 '21 13:08 codecov-commenter

🚀 Deployed on https://docs-preview-360--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] avatar Aug 27 '21 13:08 github-actions[bot]

🚀 Deployed on https://storybook-preview-360--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] avatar Aug 27 '21 13:08 github-actions[bot]