react-magma icon indicating copy to clipboard operation
react-magma copied to clipboard

A11y Documentation: Time Picker - Internationalization

Open orion-cengage opened this issue 1 year ago • 1 comments

CENG_1968

https://react-magma.cengage.com/version/4.5.0/api/time-picker/#internationalization

Issue:

The Internationalization section shows the time picker that uses a language other than English for AM and PM. If the purpose of this setting is to allow non-English speakers to set the time then the content should have the proper language attribute set. In addition, aria-labels for various inputs are in English.

Suggestion:

Use the lang attribute to set the proper language, and ensure that all labels are in the appropriate language.

orion-cengage avatar Aug 21 '24 20:08 orion-cengage

This is a problem with the Internationalization example. The code already supports using the i18n variable amButtonAriaLabel for the aria label.

silvalaura avatar Aug 21 '24 20:08 silvalaura

Width issue

Do we care if the Kanji is condensed due to the input width?

chris-cedrone-cengage avatar Oct 11 '24 13:10 chris-cedrone-cengage

I think this is okay for now and addresses the original ticket. I opened a new ticket to address the width of the AM/PM field: https://github.com/cengage/react-magma/issues/1488

silvalaura avatar Oct 11 '24 14:10 silvalaura