react-magma icon indicating copy to clipboard operation
react-magma copied to clipboard
verified publisher icon cengage

New component variant: Success button

Open orion-cengage opened this issue 1 year ago • 2 comments

Purpose: Add back in the option for a Success button.

Figma: https://www.figma.com/design/VoWYiiOKKppcYm5QLgPyDC/Components---Inputs?m=auto&node-id=1801%3A3294&t=kCWcoWKNMJ1xWcf4-1

Default theme will define the styles as follows:

image

Examples of icon button and button group with no space:

image

orion-cengage avatar May 22 '24 14:05 orion-cengage

Other considerations:

  • Adding an example to IconButton docs
  • Edge case, but how does it look in a ButtonGroup, no space?

silvalaura avatar May 22 '24 14:05 silvalaura

Great question @silvalaura . I have added examples in Figma with screenshot above.

orion-cengage avatar May 22 '24 15:05 orion-cengage

The success button was added with all variations: solid/link and !isInverse/isInverse. Corrections were made to the documentation, and the icon version was added to the IconButton section. ✅

Verified all is appearing correctly within:

https://storybook-preview-1463--upbeat-sinoussi-f675aa.netlify.app/?path=/story/button--default ✅ https://docs-preview-1463--upbeat-sinoussi-f675aa.netlify.app/api/button/ ✅ https://docs-preview-1463--upbeat-sinoussi-f675aa.netlify.app/api/icon-button/ ✅

chris-cedrone-cengage avatar Oct 09 '24 14:10 chris-cedrone-cengage