react-magma icon indicating copy to clipboard operation
react-magma copied to clipboard

CarbonCharts: Export carbon styles

Open silvalaura opened this issue 1 year ago • 4 comments

Currently our Carbon charts look great on Storybook, but don't have the correct styles in the docs site or when consuming it directly (ie CodeSandbox). This is because we are not exporting the carbon styles (@carbon/charts/styles.css) with our charts bundle. If we try to add that import when using our charts, then all our custom magma styles get overwritten.

Acceptance Criteria:

  • The carbon styles are part of the charts package so a user doesn't need to add any additional dependencies when consuming charts.

silvalaura avatar May 14 '24 13:05 silvalaura

Something happened to the titles and padding of the modal.

Image

orion-cengage avatar Jun 03 '24 14:06 orion-cengage

I didn't realize this would show up in the actual documentation, but we don't actually want to call this thing "CarbonChart." We should be transparent in the documentation that we use Carbon, but we want internal users to view this simply as "Charts."

Image

orion-cengage avatar Jun 03 '24 14:06 orion-cengage

I think it was intended for there to be a link in the opening paragraph of the docs, but it isn't rendering that way.

Image

orion-cengage avatar Jun 03 '24 14:06 orion-cengage

I have reviewed the updates and everything is looking good to me.

orion-cengage avatar Jun 04 '24 13:06 orion-cengage