react-magma icon indicating copy to clipboard operation
react-magma copied to clipboard

Fix(Badge): Fixes the Badge height for the label version. Both label and counter variants are now 24px in height.

Open chris-cedrone-cengage opened this issue 1 year ago • 3 comments

Issue: # TBD

What I did

  • Updates the label Badge height to properly align between the two variants, now both label and counter match.

Screenshots:

Alignment

Checklist

  • [x] changeset has been added
  • [x] Pull request description is descriptive
  • [N/A] I have made corresponding changes to the documentation
  • [x] New and existing unit tests pass locally with my changes
  • [x] I have added tests that prove my fix is effective or that my feature works

How to test

  • Open either Docs or Storybook
  • Go to Badge
  • Ensure the label version (default) shows a total pixel height of 24px.
  • Ensure the number version shows a total pixel height of 24px.

chris-cedrone-cengage avatar Apr 09 '24 13:04 chris-cedrone-cengage

🦋 Changeset detected

Latest commit: 50086ae36b8e1d9008d3c2bc7c7574d7056b55f8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Apr 09 '24 13:04 changeset-bot[bot]

🚀 Deployed on https://docs-preview-1228--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] avatar Apr 09 '24 14:04 github-actions[bot]

🚀 Deployed on https://storybook-preview-1228--upbeat-sinoussi-f675aa.netlify.app

github-actions[bot] avatar Apr 09 '24 14:04 github-actions[bot]