cengage
feat(CarbonCharts): Support Carbon Charts
Issue: #
WIP. Investigation into wrapping Carbon Charts inside Magma
What I did
Screenshots (if appropriate):
Checklist
- [ ] changeset has been added
- [ ] I have made corresponding changes to the documentation
- [ ] New and existing unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
How to test
🦋 Changeset detected
Latest commit: b4f5b01e9e4c3b7cf300977ef4ebd6ea9af1a4c7
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
🚀 Deployed on https://storybook-preview-1051--upbeat-sinoussi-f675aa.netlify.app
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
🚀 Deployed on https://storybook-preview-1051--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://storybook-preview-1051--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://storybook-preview-1051--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://storybook-preview-1051--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://storybook-preview-1051--upbeat-sinoussi-f675aa.netlify.app
Design feedback:
-
Focus color when tabbing through legend is still incorrect. Needs to match the light blue we use on other elements.
-
Looks like we still need a border on the checkboxes in the legend when they're turned off. Otherwise they disappear from view. Hopefully we can have the border only when they're turned off?
Please use #454545 in light mode.
Please use #FFFFFF in dark mode.
🚀 Deployed on https://storybook-preview-1051--upbeat-sinoussi-f675aa.netlify.app
Due to the update to the checkboxes, it looks like it introduced some additional styling issues.
- In light mode, the active checkboxes are now visually smaller and missing the 2px border radius, but they're fine in dark mode.
- This becomes easier to see when some checkboxes are active and others aren't.
- The checkboxes in dark mode are still missing the white outline asked for in the comment above.
🚀 Deployed on https://storybook-preview-1051--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://storybook-preview-1051--upbeat-sinoussi-f675aa.netlify.app
Everything is looking good at this point. Can't promise there won't be tweaks down the road. But consider this "Approved" without actually approving the PR.
🚀 Deployed on https://storybook-preview-1051--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://storybook-preview-1051--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://storybook-preview-1051--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://storybook-preview-1051--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://docs-preview-1051--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://storybook-preview-1051--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://docs-preview-1051--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://storybook-preview-1051--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://docs-preview-1051--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://storybook-preview-1051--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://docs-preview-1051--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://storybook-preview-1051--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://docs-preview-1051--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://storybook-preview-1051--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://docs-preview-1051--upbeat-sinoussi-f675aa.netlify.app
🚀 Deployed on https://storybook-preview-1051--upbeat-sinoussi-f675aa.netlify.app