Cemu icon indicating copy to clipboard operation
Cemu copied to clipboard

Play bootSound.btsnd while shaders/pipelines are compiling

Open goeiecool9999 opened this issue 1 year ago • 9 comments

implementation of the suggestion in issue #1045 In the process I also ended up removing some duplicate code in the way that audio initialises.

goeiecool9999 avatar Dec 17 '23 03:12 goeiecool9999

Tested on Windows but I hear nothing from bootSound.btsnd, is this option enabled by default? Edit: Ah I see the problem, bootSound.btsnd will not be played when the latency of the audio is set to 0ms

Adamillo avatar Dec 23 '23 20:12 Adamillo

And I found another bug. XAudio2 does not work properly with this PR no matter what latency you set it to

Adamillo avatar Dec 23 '23 20:12 Adamillo

Latest version should work on all API's and latency settings. Unrelated but I think before merging these changes it's probably a good idea to make this functionality disabled by default. I think it would be startling for users who update to suddenly hear audio when loading a game. When someone has short loading times it will play just a little bit of the audio and then abruptly cut out which also isn't very polished. I also heard that audio dropouts like that can blow up speakers in exceptional cases.

goeiecool9999 avatar Dec 24 '23 00:12 goeiecool9999

The audio drop out is definitely a problem that could make your PR get blocked from merging (I say could, because I am not a maintainer). Is there a way to make the audio fade out smoothly without complicating the code?

Adamillo avatar Dec 24 '23 09:12 Adamillo

I may have overstated how bad of an issue it is. Going from sound to silence like that happens every time you pause a YouTube video. So I recon anyone dealing with audio systems that could actually be damaged from that knows to be extra careful when hooking up computer software to it. Main concerns are the fact that it's unexpected and unpolished.

goeiecool9999 avatar Dec 24 '23 09:12 goeiecool9999

I see, makes sense. I was a little worried with the issue but I see what you mean now

Adamillo avatar Dec 24 '23 10:12 Adamillo

Any plans about reviews/merges for this PR?

Adamillo avatar Jan 12 '24 09:01 Adamillo

is this ever getting merged?? 🫤

GabIsAwesome avatar May 14 '24 12:05 GabIsAwesome

Any updates on this PR?

Adamillo avatar Jul 26 '24 09:07 Adamillo