CircleOfFifths icon indicating copy to clipboard operation
CircleOfFifths copied to clipboard

accidental rendering

Open vinnyt opened this issue 6 years ago • 1 comments

I am trying to figure out how to make the rendering of the notes a little more intelligent. There are situations where multiple instances of the same note show in the circle so. Think G major, G A B C D E F#, in the view however it shows as G A B C D E Gb, while technically correct when talking about G major, for example, it is a little weird to think of the scale in terms of "G A B C D E Gb".

I thought the variable preferredAccidentIsFlats would impact this behavior, but changing it has no impact on what is rendered in the view, any other ideas?

vinnyt avatar Dec 27 '18 14:12 vinnyt

@cemolcay any thoughts on this one, if you can point me at where to look in the code, I would be happy to fix.

vinnyt avatar Jan 22 '19 15:01 vinnyt