Charlotte Emms

Results 43 issues of Charlotte Emms

## What does this change? Uses the DCR support header in the new `TopBar` component (see https://github.com/guardian/dotcom-rendering/pull/11190) In doing this, also: - Adds new Storybook stories for the SDC components...

dotcom-rendering

## What does this change? Follow-up PR for https://github.com/guardian/dotcom-rendering/pull/11772 - Moves the logic for whether a card has a "dark" background into a central `libs` location rather than living directly...

dotcom-rendering

## What does this change? - Extracts the pillars definition into their own component with Storybook story - There's a "showBurgerMenu" prop to allow variation between the desktop designs and...

dotcom-rendering
fairground

## What does this change? ## Why? ## Screenshots | Before | After | | ----------- | ---------- | | ![before][] | ![after][] | [before]: https://example.com/before.png [after]: https://example.com/after.png

dotcom-rendering
fairground

The `toggleContainer` function in the `ShowHideContainers` component seems sets the `data-link-name` attributes correctly but when clicking on the button on a front container, the click event looks like the opposite...

Bug

## What are you changing? - Removes the styles that offset the underline on `Link` components ## Why? - Better alignment between all platforms, and agreed by the Design Systems...

📦 npm

## What does this change? As a follow-up from https://github.com/guardian/frontend/pull/27445, this PR removes the `fixed/highlights` container now that usages have been migrated to the `scrollable/highlights` type ## Screenshots ## Checklist...

fairground

## What does this change? Prevents Highlights container with `scrollable/highlights` type appearing in the main section of the front page. ## Why? This change was missed in https://github.com/guardian/dotcom-rendering/pull/12236 which ensures...

dotcom-rendering
fairground

## What does this change? As a follow-up from https://github.com/guardian/dotcom-rendering/pull/12236, this PR removes the `fixed/highlights` container now that usages have been migrated to the scrollable/highlights type ## Why? ## Screenshots...

dotcom-rendering

## What does this change? Updates the playwright e2e tests to work with the new redesigned header. Also identifies current issues with the new header ## Why? We need to...

dotcom-rendering