Mailjs icon indicating copy to clipboard operation
Mailjs copied to clipboard

expose response status code in IResult

Open Xiphe opened this issue 6 months ago • 0 comments

Hi! Thanks for the great library!

I think it would be great if the IResult would also expose the response status-code as currently it's pretty hard to debug why a request is failing.

Xiphe avatar Jan 15 '24 17:01 Xiphe

Note: I did not add a fix. I only added a failing test (inspired from https://github.com/romgain/react-select-event/pull/47 )

ledenis avatar Dec 03 '22 13:12 ledenis

Thanks a lot for reporting this @ledenis !

Would you be able to contribute a fix? Thank you!

romgain avatar Dec 03 '22 14:12 romgain

I was thinking about it, not sure if I can find a reliable fix. I saw that an attempt has been made to improve getReactSelectContainerFromInput but it caused bugs then reverted : https://github.com/romgain/react-select-event/pull/86

Meanwhile, I found a workaround: pass a custom container

    await selectEvent.select(mondayInput, "Chocolate", {
      container: () => mondayInput.closest('[class$="-container"]')!,
    });

A similar approach was found by someone else: https://stackoverflow.com/questions/70018351/react-select-event-doesnt-trigger-the-onchange-function-to-set-the-value-during

ledenis avatar Dec 03 '22 16:12 ledenis

I pushed a fix :tada:

ledenis avatar Dec 03 '22 22:12 ledenis