v055b: Orbot setup for TCP immediately switches to None

[ignoramous]

Investigate.

https://github.com/celzero/rethink-app/issues/1258#issuecomment-1987131283

[ThreeDeeJay]

This means, Rethink failed connecting to Orbot. I don't think Rethink switches to "None" otherwise, but we'll take a look: #1261 Do you know if it happens all the time or just randomly? Any set of steps that makes this behaviour more likely?

I may have found steps to reproduce: at least part of it

• Start with a working Orbot proxy connection (at least with TCP since HTTP still fails)
• Force close the Orbot app
• In ReThink, set Orbot to None (default) then Dismiss
• Select TCP-only proxy and it should attempt "Setting up Orbot..." then fall back to None (default)
• Open the Orbot app
• Select TCP-only proxy again
• You should notice now it falls back to None immediately, instead of waiting for Orbot to connect like when it's force closed, though (NOTICE: Bootstrapped 100% (done): Done in the Orbot log seems to be a good indicator that ReThink is ready to connect, though even then ReThink seems to attempt starting Orbot again, judging by Ignoring start request, already started. so perhaps they just need to be more on the same page)

I'm not sure what caused ReThink to fall back to None consistently, perhaps Orbot happened to have issues connecting for some reason, but I think the behavior should be more consistent and reliable (IMO it should always stay locked in whichever Orbot mode is selected in ReThink and just block connections until it can establish a connection to Orbot, to prevent leaked traffic, plus another indicator of Orbot status would be nice 👌) EDIT: Just saw https://github.com/celzero/rethink-app/issues/976 and https://github.com/celzero/rethink-app/issues/1065