v055b: Per-app trusted domains are ignored

[ignoramous]

It's seems the latest version v0.5.5b introduced a regression where per-applications trusted domains are ignored (they remain blocked) if said domains are included in a DNS blocklist :( Universally trusted domains are still honored, though.

Originally posted by @BayLee4 in https://github.com/celzero/rethink-app/issues/1120#issuecomment-1975205541

[ignoramous]

I can reproduce this. We'll fix this in a fast follow release.

[ignoramous]

fix: https://github.com/celzero/rethink-app/pull/1240/commits/d0c988aa37422ebd67656a54b4909e9e223baaf4

[BayLee4]

Thanks a lot to both of you @ignoramous and @hussainmohd-a!

[Robert-K]

I'm still running into the issue of trusted IPs and domains getting blocked for blocked apps on d24918c (even univerally bypassed IPs). Are you sure the fix works as intended? Or am I misunderstanding how blocking/trusting works?

[ignoramous]

Are you on version v055c? Check the footer of the "About" UI for the version.

[Robert-K]

Yes I'm positive. Could confirm this behaviour on multiple devices.

[ignoramous]

Unsure what's going on. Can you see if on any one of those devices, a fresh Rethink install makes trusted domains work?

Also, if user-selected DNS upstream resolver (and not on-device blocklist) blocks a trusted domain, Rethink won't be able unblock it. Check the DNS logs if the domain is blocked by the upstream (like dns.adguard.com, for example). Trusted domains are guaranteed to bypass on-device blocklists but not content-blocking upstream resolvers (like dns.adguard.com).

Trusting domains only fully works with System DNS or RDNS or an non-blocking upstream resolver (like, Cloudflare / Quad9).

[ignoramous]

We've fixed a related bug #1431 in v055j (github, website).

Can you let us know if you still see this issue?

[hussainmohd-a]

Closing the issue. Please feel free to reopen it if the issue persists.