lxp-bridge icon indicating copy to clipboard operation
lxp-bridge copied to clipboard

Breaking changes planned for 1.0

Open celsworth opened this issue 3 years ago • 4 comments

Planned breaking changes for the 1.0 release:

  • [x] remove v_pv JSON key (sum of v_pv_*, bit useless) (#135) (already done)
  • [ ] remove lxp/cmd/*/inputs/* in favour of newer lxp/cmd/*/input/*
  • [ ] remove result topics
  • [ ] remove database storage?
  • [ ] Remove inputs/1, inputs/2, inputs/3 and inputs/all - see #245

Removing Database Storage?

Bit of further discussion on the point above. Honestly I wish I'd never added this, or at least not using sqlx's "AnyPool" which supports connecting to sqlite/mysql/postgres dynamically - it seems a bit of an unloved child of sqlx, I had a hell of a time getting it to work and now sqlx 0.7 appears to have changed it all so until I want to sink 3 hours into messing with it, we're stuck on sqlx 0.6 which is using a vulnerable libsqlite. ugh!

I'm not even sure if anyone uses this. I expect most people are content with MQTT and maybe a few use InfluxDB (which is as simple as anything to add and maintain). If you rely on the database storage please leave a comment below.

celsworth avatar Nov 10 '22 21:11 celsworth

Is this likely to affect people who use just the Home Assistant function?

chriscn avatar Nov 11 '22 15:11 chriscn

The two items planned so far, no probably not. The v_pv key isn't one of the more useful ones so I doubt anyone uses it at all, and the second item is just referring to when you publish to lxp/cmd/all/inputs/1 to get the inverter to publish readings manually.

No need for panic though, I'm just collating ideas, there will be plenty of warning before any of this hits a release :) They might not even all make it.

If any breaking changes are made I'll fully document them in the wiki and release notes at the time.

celsworth avatar Nov 11 '22 15:11 celsworth

Is there a timeline for v1.0.0?

Many thanks again for all the work you've put into this project.

chriscn avatar Dec 09 '22 12:12 chriscn

I don't have a timeline for 1.0 at the moment no - still quite a lot of changes going on that revert or improve earlier changes in breaking ways and would be harder to do if we had to guarantee some sort of stability which usually comes with a 1.0 release.

Maybe some time next year if things settle down? (ie not so many new features coming and going all the time)

celsworth avatar Dec 09 '22 12:12 celsworth