celo-monorepo icon indicating copy to clipboard operation
celo-monorepo copied to clipboard

Files regarding Baklava update to CR8

Open martinvol opened this issue 1 year ago • 1 comments

Description

A few sentences describing the overall effects and goals of the pull request's commits. What is the current behavior, and what is the updated/expected behavior with this PR?

Other changes

Describe any minor or "drive-by" changes here.

Tested

An explanation of how the changes were tested or an explanation as to why they don't need to be.

Related issues

Backwards compatibility

Brief explanation of why these changes are/are not backwards compatible.

Documentation

The set of community facing docs that have been added/modified because of this change

martinvol avatar Sep 29 '22 14:09 martinvol

Pasting the output of check versions here

% yarn check-versions -a core-contracts.v3 -b core-contracts.v8 -r "report_origianl_baklava.json"
yarn run v1.22.17
$ ./scripts/bash/check-versions.sh -a core-contracts.v3 -b core-contracts.v8 -r report_origianl_baklava.json
 - Checkout contracts source code at core-contracts.v3
 - Contract artifacts already built at build/core-contracts.v3
 - Checkout contracts source code at core-contracts.v8
 - Contract artifacts already built at build/core-contracts.v8
 - Checkout migrationsConfig.js at core-contracts.v8
$ /Users/martinvol/celo/celo-monorepo/node_modules/.bin/ts-node scripts/check-backward.ts sem_check --old_contracts build/core-contracts.v3/contracts --new_contracts build/core-contracts.v8/contracts --exclude '.*Test|Mock.*|I[A-Z].*|.*Proxy|MultiSig.*|ReleaseGold|SlasherUtil|UsingPrecompiles' --output_file report_origianl_baklava.json
Running storage report...Done
Running code report...Done
Running library linking...Done
Generating backward report...Done
Writing compatibility report to report_origianl_baklava.json ...Done
Version mismatch detected:
{
    "contracts": {
        "Accounts": {
            "oldVersion": {
                "storage": 1,
                "major": 1,
                "minor": 1,
                "patch": 1
            },
            "newVersion": {
                "storage": 1,
                "major": 1,
                "minor": 4,
                "patch": 0
            },
            "expectedDelta": {
                "storage": "=",
                "major": "=",
                "minor": "+1",
                "patch": "0"
            }
        },
        "Election": {
            "oldVersion": {
                "storage": 1,
                "major": 1,
                "minor": 1,
                "patch": 0
            },
            "newVersion": {
                "storage": 1,
                "major": 1,
                "minor": 2,
                "patch": 1
            },
            "expectedDelta": {
                "storage": "=",
                "major": "=",
                "minor": "+1",
                "patch": "0"
            }
        },
        "ExchangeBRL": {
            "oldVersion": null,
            "newVersion": {
                "storage": 1,
                "major": 2,
                "minor": 0,
                "patch": 0
            },
            "expectedDelta": {
                "storage": "=",
                "major": "+1",
                "minor": "0",
                "patch": "0"
            }
        },
        "Governance": {
            "oldVersion": {
                "storage": 1,
                "major": 2,
                "minor": 0,
                "patch": 2
            },
            "newVersion": {
                "storage": 1,
                "major": 2,
                "minor": 1,
                "patch": 1
            },
            "expectedDelta": {
                "storage": "=",
                "major": "=",
                "minor": "+1",
                "patch": "0"
            }
        },
        "GrandaMento": {
            "oldVersion": null,
            "newVersion": {
                "storage": 1,
                "major": 1,
                "minor": 0,
                "patch": 1
            },
            "expectedDelta": {
                "storage": "=",
                "major": "+1",
                "minor": "0",
                "patch": "0"
            }
        },
        "MetaTransactionWallet": {
            "oldVersion": {
                "storage": 1,
                "major": 1,
                "minor": 0,
                "patch": 1
            },
            "newVersion": {
                "storage": 1,
                "major": 1,
                "minor": 1,
                "patch": 1
            },
            "expectedDelta": {
                "storage": "=",
                "major": "=",
                "minor": "+1",
                "patch": "0"
            }
        },
        "Reserve": {
            "oldVersion": {
                "storage": 1,
                "major": 1,
                "minor": 2,
                "patch": 0
            },
            "newVersion": {
                "storage": 1,
                "major": 1,
                "minor": 2,
                "patch": 2
            },
            "expectedDelta": {
                "storage": "=",
                "major": "=",
                "minor": "=",
                "patch": "+1"
            }
        },
        "Validators": {
            "oldVersion": {
                "storage": 1,
                "major": 2,
                "minor": 0,
                "patch": 0
            },
            "newVersion": {
                "storage": 1,
                "major": 2,
                "minor": 0,
                "patch": 3
            },
            "expectedDelta": {
                "storage": "=",
                "major": "=",
                "minor": "=",
                "patch": "+1"
            }
        }
    }
}

martinvol avatar Oct 04 '22 12:10 martinvol