celo-monorepo
celo-monorepo copied to clipboard
Consider how to treat discrepancies in success and version fields of signer responses
Currently, signer responses received by the combiner are filtered for successes in CombineAction
. Consider whether we want to handle discrepancies in the success
and version
fields of responses differently
The combiner response separation also makes it difficult to: process/use returned domainState or quotaStatus in the case that a PNP or domain /sign call failed with an out-of-quota and signer responses. Ideally, we would want to process & return quota returned from those responses to give users more information about these failures.
Refactoring this is likely a more involved change and will require additional testing.
Sprint planning:
- ticket to investigate how to deal with discrepancies
- but might need to restructure files
- Alec - slightly unintuitive behaviour in the code (hard to reason about logic)
- Eela - won't block functionality (more nice to have)
- Alec - probably doesn't need to happen pre merge
Sprint planning:
- Alec - nice to have
This is also related to why we can't return quota status information from the combiner on pnpSign responses
TODO: update this ticket accordingly