celo-monorepo icon indicating copy to clipboard operation
celo-monorepo copied to clipboard

Bump version of MetaTransactionWalletDeployer

Open m-chrzan opened this issue 2 years ago • 1 comments

Description

The protocol-test-release CI check started failing a few commits to master ago, claiming that the MetaTransactionWalletDeployer needs a patch version number bump. The failure was introduced in #9732. Initially I was confused why that would be the case, given the PR doesn't touch the Deployer contract, and only modifies comments, which normally shouldn't impact version numbers, since we ignore metadata stored in bytecodes when checking versions.

However, the PR does modify the MetaTransactionWalletProxy, which is imported in the Deployer contract, specifically in order to be able to deploy these proxies when deploying a fresh MTW. This means the entire proxy bytecode is inlined in the Deployer's bytecode, including the metadata, which could have changed upon modifying a comment.

This technically could be considered a change that shouldn't warrant a version number change, but given the effort that would be required to handle this sort of case in the version checker, I think it's better to just bump the version number.

Tested

The version check passes. As explained above, verified that this is a version change that makes sense.

Related issues

  • Fixes #9752

m-chrzan avatar Aug 17 '22 11:08 m-chrzan

Thanks!

aaronmgdr avatar Aug 17 '22 11:08 aaronmgdr