celo-monorepo icon indicating copy to clipboard operation
celo-monorepo copied to clipboard

ODIS 2.0.0

Open alecps opened this issue 2 years ago • 2 comments

Description

A few sentences describing the overall effects and goals of the pull request's commits. What is the current behavior, and what is the updated/expected behavior with this PR?

Other changes

Describe any minor or "drive-by" changes here.

Tested

An explanation of how the changes were tested or an explanation as to why they don't need to be.

Related issues

  • Fixes #[issue number here]

Backwards compatibility

Brief explanation of why these changes are/are not backwards compatible.

Documentation

The set of community facing docs that have been added/modified because of this change

alecps avatar Jul 21 '22 19:07 alecps

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
4218544 Generic Private Key 9001c82679540782375483bae69f5a7af80063b1 packages/sdk/identity/src/odis/circuit-breaker.mock.ts View secret
4218544 Generic Private Key 36adc12e4bda61d4823c31609d82776204742d5c packages/docs/sdk/docs/identity/classes/odis_circuit_breaker_mock.mockcircuitbreaker.md View secret
4218544 Generic Private Key 36adc12e4bda61d4823c31609d82776204742d5c packages/docs/sdk/docs/identity/modules/odis_circuit_breaker_mock.md View secret
4218544 Generic Private Key 36adc12e4bda61d4823c31609d82776204742d5c packages/docs/sdk/docs/identity/modules/odis_circuit_breaker_mock.md View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Aug 19 '22 17:08 gitguardian[bot]

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Aug 19 '22 17:08 gitguardian[bot]