celo-monorepo icon indicating copy to clipboard operation
celo-monorepo copied to clipboard

[Bounty] Disallow zero value locked celo operations

Open yorhodes opened this issue 5 years ago • 3 comments

Expected Behavior

GoldWithdrawn, GoldLocked, GoldRelocked, GoldUnlocked should not emit when value is 0 (and corresponding operations should be prevented)

AccountsSlashed?

Current Behavior

Locked Celo operations are used to trace internal celo transfers by indexers, which leads to a false positive when value is 0

Discovered by coinbase in rosetta operation See fix: https://github.com/celo-org/rosetta/pull/160

yorhodes avatar Apr 26 '21 16:04 yorhodes

Would be interested in working on this and made the changes suggested in the PR linked above. wanted to know the test cases to be followed and any other contributor guidelines to be followed as this is my first contribution to this repo. Thanks!

covendev avatar May 23 '22 19:05 covendev

cc @yorhodes @alecps @aslawson , I have made the changes and linked the PR, but the test was failing for lint step any hints on how to resolve and if any additional changes to be made apart from PR

covendev avatar May 28 '22 10:05 covendev

cc @yorhodes @alecps @aslawson , I have made the changes and linked the PR, but the test was failing for lint step any hints on how to resolve and if any additional changes to be made apart from PR

The Rosetta PR build fails because the code is not formatted properly

hbandura avatar Oct 14 '22 19:10 hbandura

This issue is stale and will be closed in 30 days without activity

github-actions[bot] avatar Jul 12 '23 14:07 github-actions[bot]