celo-monorepo icon indicating copy to clipboard operation
celo-monorepo copied to clipboard

Published 20 hours ago • verified publisher icon celo-org

Whitelist Should Not Accept New Fee Currencies Without An Oracle Price

Open karbafoo opened this issue 3 years ago • 4 comments

Description

Updated addToken function to reject tokens without a valid oracle price

Other changes

Tested

unit tests added

Related issues

  • Fixes #7315

Backwards compatibility

initialize method needs a register address. addToken change doesnt effect other features

karbafoo avatar Mar 29 '21 13:03 karbafoo

should I make the list unique ?

karbafoo avatar Mar 30 '21 04:03 karbafoo

If you mean the fee currency whitelist, I think that is a good point, but I wouldn't worry about it in this PR

nambrot avatar Mar 31 '21 21:03 nambrot

I missed that this was introducing a new storage variable which would necessitate initialization.

I am working on a resolution for this problem. @karbafoo there is no further action needed from you at this time and I will make sure that your bounty assignment doesn't expire.

yorhodes avatar Apr 06 '21 19:04 yorhodes

This PR is stale and will be closed in 30 days without activity

github-actions[bot] avatar Oct 07 '22 14:10 github-actions[bot]