celo-monorepo icon indicating copy to clipboard operation
celo-monorepo copied to clipboard

Published 20 hours ago • verified publisher icon celo-org

Docs: Fixing some terms

Open marceljay opened this issue 3 years ago • 4 comments

Description

Mostly fixing some terms like the obsolete "Gold". I specifically tried to avoid changing Gold => CELO when it was in the context of a contract or the CLI docs.

In certain instances there was some ambiguity regarding the semantics, which is why I only put CELO in brackets:

Check that the ReleaseGold contract address is associated with a registered Locked Gold (CELO) Account:

Tested

Not required, only changes to markdown.

marceljay avatar Mar 13 '21 16:03 marceljay

@YazzyYaz, adding you as a reviewer as you have good visibility into when would be a good time to make this update

critesjosh avatar Mar 15 '21 15:03 critesjosh

@marceljay as specified in this ticket: https://github.com/celo-org/celo-monorepo/pull/7425 and this ticket: https://github.com/celo-org/celo-monorepo/pull/5536 a few changes need to made for a few open CLI tickets before we commit to a full rename in the docs. Also, contracts will still retain their name Gold in this case so we need to keep that in mind. Hopefully we can resolve the doc updates soon when the CLI tickets are completed.

YazzyYaz avatar Mar 15 '21 15:03 YazzyYaz

@YazzyYaz I have tried to avoid renaming anything related to the contracts, since they obviously won't be renamed. As far as I am concerned, my PR could be merged without any logical conflicts, as I only changed the parts not related to CLI or Code.

marceljay avatar Mar 16 '21 08:03 marceljay

This PR is stale and will be closed in 30 days without activity

github-actions[bot] avatar Sep 30 '22 14:09 github-actions[bot]

That was maybe an hour of work... sad :(

marceljay avatar Nov 05 '22 15:11 marceljay