celo-monorepo icon indicating copy to clipboard operation
celo-monorepo copied to clipboard

Published 20 hours ago • verified publisher icon celo-org

ODIS combiner should retry on connection failure

Open codyborn opened this issue 4 years ago • 1 comments

Observed CELO_ODIS_ERR_09 SIG_ERR Failed to request signature from signer in the logs. This resulted from a connection failure: Logs

The alerts correctly fired however it would be great if the service gracefully handled this with retry logic with exponential back-off.

Relevant code can be found here: https://github.com/celo-org/celo-monorepo/blob/1f7aa084a9f66ff0264a372cfdcb6d9bc7924642/packages/phone-number-privacy/combiner/src/signing/get-threshold-signature.ts#L304

codyborn avatar Feb 26 '21 01:02 codyborn

This could be easily knocked out either as a drive by in CIP40 work and/or as an ODIS onboarding ticket

alecps avatar Mar 07 '22 14:03 alecps

Sprint planning:

  • On Alec's backlog (to not lose track of it)
  • Basically want to look at the code
  • Doesn't seem super high priority
  • Eela - this is a problem in the existing ODIS logic
  • Eela - perhaps get back to this after the merge (more nice to have)
  • Alec agrees
  • This could be in the after merge bucket
  • P0 before merge
  • P1 after merge, before deploy
  • We'll keep P3 as "after deploy"

arthurgousset avatar Sep 15 '22 15:09 arthurgousset