celo-blockchain icon indicating copy to clipboard operation
celo-blockchain copied to clipboard

Published 20 hours ago • verified publisher icon celo-org

fix #1927: upgrade btcd

Open vikstrous2 opened this issue 2 years ago • 2 comments

Description

Upgrading some dependencies - see #1927 Ported https://github.com/ethereum/go-ethereum/pull/24533 and made some extra changes to make things work

Other changes

Some changes ported from https://github.com/ethereum/go-ethereum/pull/24533 might not have been absolutely necessary (ex. fixing a typo)

Tested

Existing tests

Related issues

  • Fixes #1927

Backwards compatibility

According to #24533, the changes are perfectly compatible and affect only non-cgo builds anyway. Looks like celo-blockchain can't build without cgo yet, so this is definitely not going to be an issue.

vikstrous2 avatar Jul 18 '22 13:07 vikstrous2

@vikstrous2 I haven't had time to review this yet, but could you resolve the conflicts still? Thanks

hbandura avatar Aug 18 '22 23:08 hbandura

Rebased. It seems like CI is not configured to run against PRs from forks?

vikstrous2 avatar Aug 29 '22 22:08 vikstrous2

Bump? This is blocking us from being able to upgrade our btcd dependency (unless we fork celo-blockchain).

vikstrous2 avatar Nov 28 '22 22:11 vikstrous2

@vikstrous2 we've updated our CI config to run forked PRs, if you could merge master again and resolve the conflicts then we can see how CI fares.

piersy avatar Nov 29 '22 17:11 piersy

rebased

vikstrous2 avatar Jan 10 '23 20:01 vikstrous2

@vikstrous2 Thanks for this PR, I cherry-picked your commit and added a commit to disable the broken ios build in #1990.

palango avatar Jan 19 '23 15:01 palango