celo-blockchain icon indicating copy to clipboard operation
celo-blockchain copied to clipboard

Published 20 hours ago • verified publisher icon celo-org

Set default genesis in mobile client from network ID

Open nategraf opened this issue 3 years ago • 4 comments

Description

A few sentences describing the overall effects and goals of the pull request's commits. What is the current behavior, and what is the updated/expected behavior with this PR?

Other changes

Describe any minor or "drive-by" changes here.

Tested

An explanation of how the changes were tested or an explanation as to why they don't need to be.

Related issues

  • Fixes #[issue number here]

Backwards compatibility

Brief explanation of why these changes are/are not backwards compatible.

nategraf avatar Jan 25 '22 00:01 nategraf

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 6520d1421f73daaae88e67888de30c79cb307cdd

coverage: 45.4% of statements across all listed packages
coverage:  54.6% of statements in consensus/istanbul
coverage:  45.3% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  43.3% of statements in consensus/istanbul/backend/internal/db
coverage:  24.1% of statements in consensus/istanbul/backend/internal/enodes
coverage:  22.4% of statements in consensus/istanbul/backend/internal/replica
coverage:  66.0% of statements in consensus/istanbul/core
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  75.3% of statements in consensus/istanbul/uptime
coverage: 100.0% of statements in consensus/istanbul/uptime/store
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random
CommentID: 901e9401c1

piersy avatar Jan 25 '22 00:01 piersy

And one more question, what about the backward compatibility for existing Valora users who had been initializing the node by passing the genesis data? Is there some persisted data somewhere down the line that would create a problem by switching from passing the genesis data to not passing it anymore? Especially related to the Espresso hardfork.

jeanregisser avatar Jan 25 '22 08:01 jeanregisser

And one more question, what about the backward compatibility for existing Valora users who had been initializing the node by passing the genesis data? Is there some persisted data somewhere down the line that would create a problem by switching from passing the genesis data to not passing it anymore? Especially related to the Espresso hardfork.

If we additionally change Valora to not pass in the chain config parameters, I don't think there should be an issue. This is certainly something we should test.

nategraf avatar Jan 25 '22 18:01 nategraf

Following the process for making releases, this PR should be merged to master first, then cherry picked back to release/1.5.x

nategraf avatar Jan 26 '22 00:01 nategraf