celluloid icon indicating copy to clipboard operation
celluloid copied to clipboard

Can't drag and drop subtitles in the flatpak version.

Open mkblast opened this issue 2 years ago • 12 comments

Overview Description: when you use the flatpak version and you want to attach a subtitle and you drag it to the player from the file manager (GNOME files), the file wont load, the only way to load a subtitle it to use the file picker. Steps to Reproduce:

  1. Try to load a subtitle by draging it from the file manager.

Actual Results: The subtitle wont load.

Expected Results: Load normally

Version: 0.23

Additional Information: IDK but im using Fedora 36 under wayland.

mkblast avatar May 12 '22 16:05 mkblast

This should start working once Files is ported to GTK4.

gnome-mpv avatar May 13 '22 02:05 gnome-mpv

Same issue, running on Cinnamon, in Linux Mint 21, with Nemo (v5.4.3) as file manager and Celluloid 0.21 installed through APT package from Mint distribution (i.e. not Flatpak).

brainchild0 avatar Oct 07 '22 05:10 brainchild0

This should start working once Files is ported to GTK4.

After updating to Fedora 37 with Files in GTK4 I still have this issue
Screencast from 2022-11-15 19-57-13.webm

mkblast avatar Nov 15 '22 18:11 mkblast

Sorry I miss clicked and closed the Issue.

mkblast avatar Nov 15 '22 18:11 mkblast

Ok so I thought it could be a Flatpak problem so I went and search for other Flatpak and try if they have the same issue but I don't think so, I tested it with two apps Amberol and G4Music and they don't have the problem.

Screencast from 2022-11-16 18-17-23.webm

And I tried with Flatpak MPV and no issue again I think this is a celluloid only bug.

Screencast from 2022-11-16 18-23-05.webm

mkblast avatar Nov 16 '22 17:11 mkblast

I am reproducing in a standard execution environment, not Flatpak, as I reported earlier.

brainchild0 avatar Nov 16 '22 18:11 brainchild0

@mkblast Should be fixed in 8ec48921e6c24de2fef5bf63f12d1ba55ede6036.

@brainchild0 I can't reproduce the problem with Nemo on GNOME, so the problem might be specific to Cinnamon. I'll have to set up a VM to test later. There's a small possibility that the patch above fixes your problem as well, so you may want to try it out.

gnome-mpv avatar Nov 17 '22 05:11 gnome-mpv

@brainchild0 I just tested with a Linux Mint VM and DnD works fine for me. I tested both v0.21 and v0.24.

gnome-mpv avatar Nov 17 '22 06:11 gnome-mpv

I haven't had a chance for a thorough test at the moment, but I am now finding that if the titles file is local, then results are as expected, but if the file is on a remote SMB/CIFS share (mounted through the GIO interface provided in the file manager), then attempts to add the titles file to a video asset already loaded fails silently.

Are you able to attempt a test case with a similar structure?

The problem loading files through drag-in-drop is not appearing for a video asset itself, only a titles sequence from a separate file.

For reference, I am currently running Nemo 5.4 and Celluloid 0.21 as provided by the LM repositories.

brainchild0 avatar Nov 17 '22 17:11 brainchild0

@brainchild0 Should be fixed with eeaabcf460c8e0a29d48d731aec55283bfac04a9.

gnome-mpv avatar Nov 19 '22 19:11 gnome-mpv

Great. Thanks for applying the fix. Unfortunately, it is extremely slow for any application revision to enter into the OS distribution repositories. It will likely be some time before the new functionality is reflected by my system update.

brainchild0 avatar Nov 19 '22 19:11 brainchild0

Should be fixed in 8ec4892.

Thanks for applying the fix, looking forward to trying it in the next update, when it rolls out and I test it ill close the issue.

mkblast avatar Nov 19 '22 20:11 mkblast