[0.28] Minor redesign issues

[Acumane]

UI redesign issues:

• [ ] Floating controls don't use GTK theme foreground color
• [x] Timestamp label artifacts on scrub:
• [x] Control slide in/out is choppy and slightly distracting
• [ ] Do we really need to see all the titlebar buttons in fullscreen?
• [x] All control menus are opaque except for volume slider
• [ ] Immediately fullscreens on open. Why?

[gnome-mpv]

Floating controls don't use GTK theme foreground color

It's not supposed to do that. Floating controls uses the osd class which has its own colors.

Timestamp label artifacts on scrub

I'm unable to reproduce this. It looks like this could be a GPU driver bug though.

Control slide in/out is choppy and slightly distracting

This is a known issue. Setting video-timing-offset=0 and video-sync=audio will resolve the issue at the cost of a small amount of audio/video desync.

Do we really need to see all the titlebar buttons in fullscreen?

There are supposed to be only 3 buttons in the top part of the screen. Are you seeing more?

All control menus are opaque except for volume slider

~It looks like the osd style isn't being applied to these popovers. I'm looking into it.~ Fixed in cef14a8a460b2779cf5baeeccc3d7aa93c009b90.

Immediately fullscreens on open. Why?

It's not supposed to do that. Can you generate a log file and post it here?

[Acumane]

It's not supposed to do that. Floating controls uses the osd class which has its own colors.

Bit strange since even the osd dropdowns use the GTK theme but ok. How does osd retrieve these colors if not through osd-color, which has no effect?

Do we really need to see all the titlebar buttons in fullscreen?

This is just an aesthetic preference. I don't know who needs to see "Open" and "Main Menu" while fullscreened.

Can you generate a log file and post it here?

Reproed w/o my config: celluloid.log

[gnome-mpv]

Bit strange since even the osd dropdowns use the GTK theme but ok. How does osd retrieve these colors if not through osd-color, which has no effect?

It should come straight from the theme, which is Adwaita by default. If you have a custom theme and it doesn't define a color for .osd, I think the color from Adwaita will be used, but I'm not complete sure. You can override the color using a custom css with this selector: box.osd.

This is just an aesthetic preference. I don't know who needs to see "Open" and "Main Menu" while fullscreened.

The main menu can be used to switch subtitle tracks, which I think is a pretty common operation even in fullscreen. In any case, I don't think they're disruptive enough to warrant hiding by default, but you may be able to use custom css to hide them anyway.

Reproed w/o my config: celluloid.log

From the log, it looks like the window is just maximized, not fullscreen. They can look pretty similar if you're using floating controls though.

If you previously closed the window while it is maximized, it's supposed to remember that and auto-maximize on the next launch. Unmaximizing the window and closing it should fix it.

[Acumane]

This works:

.osd, .floating-header {
    color: #DCD7BA;
}

Though removing particular elements is a little difficult without classes or other unique identifiers.

I'm still using Adwaita but with a colorscheme that overrides accent_fg_color, destructive_fg_color, success_fg_color, warning_fg_color, error_fg_color, window_fg_color, view_fg_color, headerbar_fg_color, card_fg_color, dialog_fg_color, and popover_fg_color.

I think this list is fairly comprehensive. It's never failed me in any GTK application and is what Gradience uses. osd should probably fall back to one of these.

Unmaximizing the window and closing it should fix it.

Regardless of the previous state, it still maximizes

[gnome-mpv]

Regardless of the previous state, it still maximizes

My guess would be that the window state isn't being saved for some reason, but I have no idea what could be causing that.