rollmint
rollmint copied to clipboard
celestiaorg
ABCI-client implementation for rollups.
currently the `dataHash` field in the header is populated using `data.Hash()` a simple merkle tree hash. this needs to be changed to commitment obtained by calling the `createCommitment`.
in `DataStoreRetrieveLoop` there is no immediate rejection logic for any junk sent over the p2p for `Data`. the p2p `validate` checks for `lastDataHash`, but this can easily be incorporated in...
### Version of Git SHA none ### System OS pop! os ### Installed tools go ### Others _No response_ ### Steps to reproduce it curl -sSL https://rollkit.dev/install.sh | sh -s...
### Implementation ideas Looking at the code: https://github.com/rollkit/rollkit/blob/a95825f7ac1a1813acd3a7ced71aa838efa0cefb/cmd/rollkit/commands/run_node.go#L121-L129 It seems a mock DA server is initialised if the user doesn't pass a value with the `--rollkit.da_address` flag explicitly. The default...
``` === NAME TestREST service_test.go:99: Error Trace: /home/runner/work/rollkit/rollkit/rpc/json/service_test.go:99 Error: "{\"jsonrpc\":\"2.0\",\"result\":{\"block_id\":{\"hash\":\"CA7F7790577FC09E303816CAC94201914615260D3097D1A04B4BDA0F0377AA45\",\"parts\":{\"total\":0,\"hash\":\"\"}},\"block\":{\"header\":{\"version\":{\"block\":\"11\"},\"chain_id\":\"test\",\"height\":\"1\",\"time\":\"2024-08-14T19:21:25.972545451Z\",\"last_block_id\":{\"hash\":\"\",\"parts\":{\"total\":0,\"hash\":\"\"}},\"last_commit_hash\":\"EA312FCB12D4AEB315427DE61F738D6790DF83E49A83108F1B745947598950B4\",\"data_hash\":\"6E340B9CFFB37A989CA544E6BB780A2C78901D3FB33738768511A30617AFA01D\",\"validators_hash\":\"0554D6F24D8529FF529B4337E519C29516249441C316719E99E1A2D088A4A02B\",\"next_validators_hash\":\"0554D6F24D8529FF529B4337E519C29516249441C316719E99E1A2D088A4A02B\",\"consensus_hash\":\"0000000000000000000000000000000000000000000000000000000000000000\",\"app_hash\":\"\",\"last_results_hash\":\"E3B0C44298FC1C149AFBF4C8996FB92427AE41E4649B934CA495991B7852B855\",\"evidence_hash\":\"E3B0C44298FC1C149AFBF4C8996FB92427AE41E4649B934CA495991B7852B855\",\"proposer_address\":\"5E77C57BE649671B2DE2B019A910E8FFF1CFC5DF\"},\"data\":{\"txs\":[]},\"evidence\":{\"evidence\":null},\"last_commit\":{\"height\":\"1\",\"round\":0,\"block_id\":{\"hash\":\"CA7F7790577FC09E303816CAC94201914615260D3097D1A04B4BDA0F0377AA45\",\"parts\":{\"total\":0,\"hash\":\"\"}},\"signatures\":[{\"block_id_flag\":2,\"validator_address\":\"5E77C57BE649671B2DE2B019A910E8FFF1CFC5DF\",\"timestamp\":\"2024-08-14T19:21:25.972545451Z\",\"signature\":\"lVbbYWu4WLMo6t0+HaQfobd/Fy6NfjQ+63jlysqxqIunaNHx4jZCrj7rcxguG4a5GUouJefw/ILKpzSlmuvzDw==\"}]}}},\"id\":-1}\n" does not contain "failed to load hash from index" Test: TestREST service_test.go:103: Error Trace: /home/runner/work/rollkit/rollkit/rpc/json/service_test.go:103 Error: Expected value not to...
Since after header and data separation, the whole block is no longer submitted to this TestFastDASync needs to be refactored to check only headers sync fast in DA than p2p.