rollmint icon indicating copy to clipboard operation
rollmint copied to clipboard

Code coverage

Open tzdybal opened this issue 2 years ago • 2 comments

This issue is a draft. Code-coverage pain points will be updated by @tzdybal.

  • [x] #1268

types:

  • [ ] Create test for types/Header.UnmarshalBinary
  • [ ] Create test for types/Data.MarshalBinary

node:

  • [ ] Create test for node/Node.GetGenesis
  • [ ] Create test for node/Node.newCommitValidator
  • [ ] Create test for node/Node.newFraudProofValidator

da:

  • [ ] Create test for da/celestia/mock/Server.writeError

p2p:

  • [ ] Create test for p2p/Client.GossipCommit
  • [ ] Create test for p2p/Client.GossipFraudProof
  • [ ] Create test for p2p/Ciient.Addrs
  • [ ] Create test for p2p/Client.Peers

Functions/methods with missing coverage

Significant amounts of uncovered code; basic error handling not taken into account.

  • [ ] types/SignedHeader.ValidateBasic
  • [ ] da/celestia/mock/appendToShares
  • [ ] block/updateState
  • [ ] config/GetNodeConfig

tzdybal avatar Nov 21 '22 14:11 tzdybal

Moved rpc/client/Client and rpc/json/service to https://github.com/rollkit/rollkit/issues/1268

nashqueue avatar Nov 10 '23 16:11 nashqueue

Requires a more extensive discussion on code coverage % Moving it to v1

nashqueue avatar Jan 05 '24 16:01 nashqueue