rollmint icon indicating copy to clipboard operation
rollmint copied to clipboard

feat: Immediate Execution with ABCI++

Open Manav-Aggarwal opened this issue 2 years ago • 1 comments

Closes: #488

  • Switches to immediate execution,
  • uses PrepareProposal when a Block Producer creates a block (CreateBlock)
  • uses ProcessProposalbefore a full node calls ApplyBlock.
  • Fixed all the corresponding tests as well to have mocks for the new ABCI methods

Uses this branch of tendermint with the new ABCI methods: https://github.com/celestiaorg/tendermint/pull/150

Note from Marko: if you are using ibc-go, staking or some other modules in the sdk for this, you will run into issues

Manav-Aggarwal avatar Oct 24 '22 14:10 Manav-Aggarwal

This should probably not be merged into main unless this was tested with the cosmos sdk. I fear it assumes deferred exec in the state machine.

Converted to draft until the trajectory of this PR is clarified.

Modified target branch to be a fork of main, in case we'd like to still review but we can merge it into a separate branch instead of main.

Manav-Aggarwal avatar Oct 25 '22 22:10 Manav-Aggarwal

Closing this since it's not clear when this will be relevant again.

Manav-Aggarwal avatar Jun 27 '24 21:06 Manav-Aggarwal