rollmint icon indicating copy to clipboard operation
rollmint copied to clipboard

Test full node catching up when far behind with blocks having lots of Txs

Open Manav-Aggarwal opened this issue 2 years ago • 2 comments

That means if I sync and I am far behind, I would be able to sync fully no matter the height difference. I think we should test how the sync of a chain (with a lot of txs) performs. Can be a follow-up. VA

Originally posted by @nashqueue in https://github.com/rollkit/rollkit/pull/1204#discussion_r1339321177

Manav-Aggarwal avatar Sep 28 '23 04:09 Manav-Aggarwal

Hi @Manav-Aggarwal, I see in the document of BlockStoreRetrieveLoop, it says It keeps track of the last retrieved block's height and every time the current block store's height is greater than the last retrieved block's height, it retrieves all blocks from the block store that are between these two heights but in the code we are set lastBlockStoreHeight = 0, so It will always retrieve from 0 to current block store's height, should we add a param in like startHeightRetrive in Manager.BlockStoreRetrieveLoop func ?

ThanhNhann avatar Mar 07 '24 07:03 ThanhNhann