optimism icon indicating copy to clipboard operation
optimism copied to clipboard

Published 20 hours ago • verified publisher icon celestiaorg

da: try using blobdata for eth fallback

Open tuxcanfly opened this issue 1 year ago • 1 comments

Overview

This PR enables allows fallback to blobdata if possible.

tuxcanfly avatar May 01 '24 23:05 tuxcanfly

Hey @tuxcanfly! This PR has merge conflicts. Please fix them before continuing review.

mergify[bot] avatar May 13 '24 21:05 mergify[bot]

Hey @tuxcanfly! This PR has merge conflicts. Please fix them before continuing review.

mergify[bot] avatar Jun 05 '24 16:06 mergify[bot]

Agreed @emilianobonassi we can simplify this to fallback to blob/call data based on a feature flag, potentially merging --da.eth_fallback_disabled flag with it into an enum.

tuxcanfly avatar Jun 13 '24 15:06 tuxcanfly

lgtm

emilianobonassi avatar Jun 17 '24 13:06 emilianobonassi

Need to add the fallback flag.

tuxcanfly avatar Jun 17 '24 13:06 tuxcanfly

Hey @tuxcanfly! This PR has merge conflicts. Please fix them before continuing review.

mergify[bot] avatar Jun 18 '24 20:06 mergify[bot]

@emilianobonassi good for another review now 👍🏽

tuxcanfly avatar Jun 19 '24 00:06 tuxcanfly

Hey @tuxcanfly! This PR has merge conflicts. Please fix them before continuing review.

mergify[bot] avatar Jun 26 '24 22:06 mergify[bot]

Hey @tuxcanfly! This PR has merge conflicts. Please fix them before continuing review.

mergify[bot] avatar Jul 02 '24 14:07 mergify[bot]

This is backward compatible as da.fallback_mode defaults to calldata, same as current fallback behaviour and the deprecated flag da.eth_fallback_disabled now configures da.fallback_mode=disabled.

tuxcanfly avatar Jul 02 '24 23:07 tuxcanfly