nmt icon indicating copy to clipboard operation
nmt copied to clipboard

Ignore proto generated files in codecover

Open rootulp opened this issue 2 years ago • 3 comments

https://github.com/celestiaorg/nmt/pull/220 added Proto definitions to this repo. We don't need the generated proto files to be covered via unit tests so we should ignore them from the code coverage workflow that runs in this repo

Thanks for the idea @vgonkivs

rootulp avatar Jul 18 '23 14:07 rootulp

Thanks for opening this issue! Do we want to proceed with this PR or do we want to wait for this fix before merging https://github.com/celestiaorg/nmt/pull/220?

staheri14 avatar Jul 18 '23 16:07 staheri14

Let's proceed with https://github.com/celestiaorg/nmt/pull/220 and tackle this issue in a follow-up PR.

rootulp avatar Jul 18 '23 18:07 rootulp