knuu icon indicating copy to clipboard operation
knuu copied to clipboard

`AddFileBytes()` should have parameter for file permission

Open smuu opened this issue 2 years ago • 8 comments

Currently it is hard coded to 0644

smuu avatar Jun 20 '23 13:06 smuu

i would like to tackle this if possible.

DRIESASTER avatar Jun 20 '23 19:06 DRIESASTER

should I edit the parameters at other places or keep 0644 as a default value?

DRIESASTER avatar Jun 20 '23 20:06 DRIESASTER

Sorry i'm kind of confused how to even run this thing. I'm on fedora and just installed docker. Where do i go from here? You say to configure my kubernetes. Is there a docker file included i'm missing?

DRIESASTER avatar Jun 20 '23 21:06 DRIESASTER

Sorry i'm kind of confused how to even run this thing. I'm on fedora and just installed docker. Where do i go from here? You say to configure my kubernetes. Is there a docker file included i'm missing?

I added content to the README and linked some resources on how to create a Kubernetes cluster.

smuu avatar Jun 21 '23 09:06 smuu

should I edit the parameters at other places or keep 0644 as a default value?

Sorry, I don't understand that question. Could you please elaborate?

smuu avatar Jun 21 '23 09:06 smuu

i assume you're calling AddFileBytes at certain places. Do you want me to make the extra parameter optional so that all the code that exists right now works as is, with a default value of 0644, but with an added option to pass an additional parameter for file permission. Or do you want me to replace all the function calls of of AddFileBytes() to include the extra parameter?

Also thanks for the readme! I'll look at it later tonight.

DRIESASTER avatar Jun 21 '23 09:06 DRIESASTER

i assume you're calling AddFileBytes at certain places. Do you want me to make the extra parameter optional so that all the code that exists right now works as is, with a default value of 0644, but with an added option to pass an additional parameter for file permission. Or do you want me to replace all the function calls of of AddFileBytes() to include the extra parameter?

Also thanks for the readme! I'll look at it later tonight.

Thanks for the clarification :rocket: I prefer non-breaking changes, so better don't replace the function and make 0644 the default :+1:

smuu avatar Jun 21 '23 09:06 smuu

Ok awesome, thanks. Could you assign this issue to me? I'll get on it.

DRIESASTER avatar Jun 21 '23 10:06 DRIESASTER