fix(e2e-523): inital commit - fixing e2e/system tests - WIP

[tty47]

closes: https://github.com/celestiaorg/knuu/issues/523

Summary by CodeRabbit

• New Features

  • Enhanced error handling in testing functions with a new retry mechanism, improving test reliability against transient errors.
  • Introduced a utility function for retry operations, facilitating multiple attempts for potentially failing actions.
  • Implemented synchronization mechanisms for concurrent access to bucket creation within the Minio service.
  • Added new configuration options for container image pull policies, enhancing deployment flexibility.
  • Increased timeout for specific GitHub Actions workflows to accommodate longer-running test processes.

• Bug Fixes

  • Improved robustness of test scenarios by addressing potential hanging issues through timeout implementations.

• Refactor

  • Streamlined test logic and renamed functions for clearer representation of test cases.
  • Removed outdated test functions to focus on relevant scenarios involving volumes and files.
  • Enhanced logging and error messages within tests for better debugging and traceability.

[coderabbitai[bot]]

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The recent changes refine the testing framework within the e2e/system tests by enhancing error handling through retry mechanisms and improved logging. Cleanup functions have been removed, which simplifies test execution but may introduce resource management concerns. Additionally, adjustments were made to GitHub Actions workflow timeouts to accommodate longer-running tests and ensure stability.

Changes

File(s)	Change Summary
e2e/system/build_from_git_test.go, e2e/system/file_test_image_cached_test.go, e2e/system/file_test.go, e2e/system/files_to_volumes_cm_test.go	Enhanced error handling with retry logic and structured logging; removal of some cleanup logic.
e2e/system/suite_setup_test.go	Introduced retryOperation for managing retries in operations.
pkg/minio/minio.go	Implemented synchronization for bucket creation using a mutex map for thread-safe operations.
pkg/k8s/errors.go, pkg/k8s/pod.go	Enhanced error messages for command execution, providing context with stdout and stderr.
pkg/instance/build.go, pkg/instance/execution.go, pkg/instance/instance.go	Added imagePullPolicy for better container configuration and improved error handling with detailed messages.
.github/workflows/knuu_testing.yml	Increased timeout for the ./e2e/basic job from 15 minutes to 30 minutes; adjusted timeout for ./e2e/system job from 15 to 60 minutes.

Assessment against linked issues

Objective	Addressed	Explanation
Fix errors in e2e/system (#523)	✅
Improve error handling in tests (#523)	✅
Ensure tests have timeouts (#523)	✅	Timeout adjustments made in workflow.
Maintain resource cleanup in tests (#523)	❌	Cleanup logic was removed, raising concerns about resource leaks.

Poem

In the system where tests reside,
A rabbit hops with joy and pride.
With retries and logs that shine so bright,
We tackle errors, ready to fight.
Though cleanup's gone, we boldly tread,
For every test, a path ahead! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mojtaba-esk]

Thanks for the great work. Now all tests are passing. Would you please resolve conflicts so we will be able to merge it?