knuu icon indicating copy to clipboard operation
knuu copied to clipboard
verified publisher icon celestiaorg

feat: `CloneWithSuffix` does not check for Instance state

Open smuu opened this issue 1 year ago • 1 comments

Clone checks for state Instance is in but CloneWithSuffix does not.

https://github.com/celestiaorg/knuu/blob/f21844326cbab7ac02332612a2aafddadd9ea0dd/pkg/instance/instance.go#L1074

https://github.com/celestiaorg/knuu/blob/f21844326cbab7ac02332612a2aafddadd9ea0dd/pkg/instance/helper.go#L375

smuu avatar Jul 26 '24 10:07 smuu

This might be fixed by #530

mojtaba-esk avatar Aug 26 '24 08:08 mojtaba-esk

I think this is already done in the PR merged, right?

tty47 avatar Oct 14 '24 11:10 tty47

I think this is already done in the PR merged, right?

Thanks for pointing it out. I am merging #570 as it has two approvals. So then we cal close it

mojtaba-esk avatar Oct 14 '24 12:10 mojtaba-esk