knuu icon indicating copy to clipboard operation
knuu copied to clipboard

Code Review Notes

Open MSevey opened this issue 1 year ago • 1 comments

Overview

This issue is a tracking issue of things found while doing a code walk through. Long task names can be shortened for issues and extra context can be put into issue body

### README
- [ ] https://github.com/celestiaorg/knuu/issues/392
- [ ] Link to documentation under tests isn't that helpful. I would just move that go pkg link to the repo description (top right)
- [ ] for kubconfig, add link directly to the kubeconfig in the k8 docs
- [ ] https://github.com/celestiaorg/knuu/issues/395
- [ ] https://github.com/celestiaorg/knuu/issues/394
- [ ] kubectl is a dependency and needs to be called out
- [ ] have CI for example on README
### General
- [ ] To be more go idiomatic, e2e/ should be test/ REF: https://github.com/golang-standards/project-layout
- [ ] add code coverage for test coverage
- [ ] https://github.com/celestiaorg/knuu/issues/403
- [ ] https://github.com/celestiaorg/knuu/issues/405
- [ ] https://github.com/celestiaorg/knuu/issues/398
- [ ] https://github.com/celestiaorg/knuu/issues/400
- [ ] https://github.com/celestiaorg/knuu/issues/406

MSevey avatar May 29 '24 13:05 MSevey

@sysrex

smuu avatar Jul 04 '24 14:07 smuu