knuu icon indicating copy to clipboard operation
knuu copied to clipboard

refactor!: have knuu as an object

Open smuu opened this issue 1 year ago • 3 comments

func Knuu(scope string) (*Knuu, error)

func (k *Knuu) GetScope() (string, error)
func (k *Knuu) CleanUp() (error)
func (k *Knuu) SetImageBuilder(b builder.Builder) (error)
func (k *Knuu) ImageBuilder() (builder.Builder, error)
func (k *Knuu) NewInstance(name string) error

If we do that before v1, please make changes backward compatible.

smuu avatar May 08 '24 08:05 smuu

This is a breaking change, we need to communicate it well to the users before cutting a release.

mojtaba-esk avatar May 15 '24 10:05 mojtaba-esk

This is a breaking change, we need to communicate it well to the users before cutting a release.

Can we add this without touching the current code?

smuu avatar May 15 '24 16:05 smuu

We can write some wrappers to support the current users, then in another release we can get rid of the wrapper and ask everyone to use it as an object.

mojtaba-esk avatar May 16 '24 11:05 mojtaba-esk