knuu icon indicating copy to clipboard operation
knuu copied to clipboard

Use Go Test Timeout to set Knuu Timeout

Open tty47 opened this issue 1 year ago • 4 comments

hello!

It would be great to set the KNUU_TIMEOUT value from go test -timeout, this will help us to specify the timeout value and don't face issues like:

Set the env var:

export KNUU_TIMEOUT=25m

And then:

panic: test timed out after 10m0s
running tests:
        TestFolderCached (10m0s)

cheers! 🚀

### Tasks
- [ ] `KNUU_TIMEOUT` -> from `go test -timeout`
- [ ] if we set `KNUU_TIMEOUT` will override `go test -timeout`
- [ ] `go test -timeout` has priority over `KNUU_TIMEOUT`

tty47 avatar Apr 12 '24 06:04 tty47

So,KNUU_TIMEOUT can only set up from go test -timeout?

Can we remove manual KNUU_TIMEOUT declaration?

nesangcode avatar Apr 12 '24 09:04 nesangcode

So,KNUU_TIMEOUT can only set up from go test -timeout?

Can we remove manual KNUU_TIMEOUT declaration?

hello!

it will be something like:

  • KNUU_TIMEOUT -> from go test -timeout
  • if we set KNUU_TIMEOUT will override go test -timeout
  • go test -timeout has priority over KNUU_TIMEOUT

tty47 avatar Apr 12 '24 10:04 tty47

did point 2 and 3 contradict each other?

nesangcode avatar Apr 13 '24 05:04 nesangcode

  • if we set KNUU_TIMEOUT will override go test -timeout

I meant: in case we specifyKNUU_TIMEOUT will override go test -timeout -> the default value if we specify the go test -timeout then, it has priority over KNUU_TIMEOUT

tty47 avatar Apr 15 '24 11:04 tty47

not possible

smuu avatar Jul 04 '24 14:07 smuu