celestia.org icon indicating copy to clipboard operation
celestia.org copied to clipboard

Change Twitter Logo to X logo on front page

Open mathaszip opened this issue 2 years ago • 3 comments

Overview

Enhancement: Implemented updated logo for X to ensure compliance with standardized formatting and cohesive visual identity, resolving a noted discrepancy on the website.

Minimal code changes: updated one line in social-channels.js and added the image x-black.png.

Requesting review and feedback, ensuring alignment with expectations.

Checklist

  • [x] New and updated code has appropriate documentation
  • [x] New and updated code has new and/or updated testing
  • [x] Required CI checks are passing
  • [x] Visual proof for any user facing features like CLI or documentation updates
  • [x] Linked issues closed with keywords

mathaszip avatar Dec 20 '23 18:12 mathaszip

Please rebase your commits on the current main. You can also open a new PR from a fresh branch and cherry-pick the commits from the old one if that is easier.

liamsi avatar Jan 15 '24 12:01 liamsi

Did I do it correctly?

mathaszip avatar Jan 15 '24 15:01 mathaszip

Please rebase your commits on the current main. You can also open a new PR from a fresh branch and cherry-pick the commits from the old one if that is easier.

I should have done it correctly now. I created a new PR to the dev branch: https://github.com/celestiaorg/celestia.org/pull/356

mathaszip avatar Jan 18 '24 15:01 mathaszip