celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

Published 20 hours ago • verified publisher icon celestiaorg

rpc: Move sanity check logic from rpc handlers to implementations

Open distractedm1nd opened this issue 2 years ago • 2 comments

There is some sanity check logic in our rpc handlers as discussed here: https://github.com/celestiaorg/celestia-node/pull/984#discussion_r938706320. This should be moved down and handled by the implementation beneath it, so that the checks don't only occur for RPC users, but also for those using the public API directly.

distractedm1nd avatar Aug 10 '22 07:08 distractedm1nd

I'm working on this, but because I can't get the unmodified code pass the unit test, I can't create the PR now.

HoytRen avatar Oct 10 '22 03:10 HoytRen

Hey there @HoytRen, you should be able to create the PR from your fork without needing to first pass unit tests - and then we can check out what is wrong with the CI :) Thank you for taking this up!

distractedm1nd avatar Oct 10 '22 07:10 distractedm1nd