celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

node/config: All time related config fields are in nanoseconds

Open Wondertan opened this issue 2 years ago • 2 comments

The default values for GracePeriod and RoutingTableRefreshPeriod are set as time.Minute, however, in the config it is written in nanoseconds which is not very human-friendly.

Instead, it should be a string that is parsed via time.ParseDuration

Wondertan avatar Jul 15 '22 16:07 Wondertan

Tentatively assigning @vgonkivs

Wondertan avatar Jul 15 '22 16:07 Wondertan

It seems this is done? in the config.toml, I see 'GracePeriod = "1m0s"', and I believe it's spf13/viper handling the duration string.

HoytRen avatar Oct 11 '22 08:10 HoytRen

Yeah I suppose this is done cc @Wondertan

derrandz avatar May 09 '23 15:05 derrandz