celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

Cleanup global variables

Open Wondertan opened this issue 2 years ago • 1 comments

In multiple places in the code, we rely on global variables, which is usually not that bad but has its downsides. Eventually, we should allocate some time to clean them up, which includes:

  • "Deglobalization" of vars. It should be straightforward to configure those via direct optionable configuration of the structs/logic that those vars affect. Currently, it's not obvious to newcomers that those do exist and that they can be configurable.
  • Pass those options/direct configurations into the Node configs, so that node operators can control them and fine-tune according to their setup
  • Consistent naming

Wondertan avatar May 13 '22 11:05 Wondertan

Putting into Q3 Roadmap as we have a refactoring planning ahead

Bidon15 avatar Jul 26 '22 13:07 Bidon15

I think we can close this @Wondertan

derrandz avatar May 09 '23 15:05 derrandz

Let's double check first. My intuition is that few of them still left that needs to be configured.

Wondertan avatar May 09 '23 15:05 Wondertan