celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

store: close accessor in GetRow and GetRangeNamespaceData

Open phrwlk opened this issue 6 months ago • 3 comments

Ensures AccessorStreamer obtained via Store.GetByHeight is always closed in GetRow and GetRangeNamespaceData. Without closing, ref-counted accessors in the cache may leak references and file descriptors, preventing proper eviction and leading to resource leaks. This change aligns these methods with the existing pattern used in GetSamples, GetEDS, and GetNamespaceData.

phrwlk avatar Sep 22 '25 16:09 phrwlk

Can you fix linter issue @phrwlk ?

Wondertan avatar Sep 25 '25 14:09 Wondertan

Codecov Report

:x: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 35.36%. Comparing base (2469e7a) to head (4eece8a). :warning: Report is 586 commits behind head on main.

Files with missing lines Patch % Lines
store/getter.go 50.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4575      +/-   ##
==========================================
- Coverage   44.83%   35.36%   -9.48%     
==========================================
  Files         265      304      +39     
  Lines       14620    24323    +9703     
==========================================
+ Hits         6555     8601    +2046     
- Misses       7313    14771    +7458     
- Partials      752      951     +199     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Sep 25 '25 14:09 codecov-commenter

Can you fix linter issue @phrwlk ?

fixed lint @Wondertan

phrwlk avatar Sep 25 '25 17:09 phrwlk