celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

Unit test for `extendBlock` on historical mainnet blocks

Open rootulp opened this issue 8 months ago • 3 comments

Context

https://github.com/celestiaorg/celestia-node/pull/4219/files#r2046888052

Proposal

It would increase confidence if celestia-node had a test for extendBlock that used block data from historical mainnet blocks. This data can be saved in testdata/ and then extendBlock can be invoked on them to verify that the generated EDS data root matches what was produced on mainnet for that block. It is worth including a few sample blocks that span app versions (v1, v2, v3) and span a few different types of tx data (regular blobs, authored blobs, empty block).

rootulp avatar Apr 29 '25 18:04 rootulp

Is it still relevant?

SaveTheAles avatar May 28 '25 16:05 SaveTheAles

Yes.

rootulp avatar May 29 '25 07:05 rootulp

on behave of @SaveTheAles (Noders team), I am gonna pick up this issue @rootulp

moldis avatar Jun 02 '25 08:06 moldis